Re: [PATCH] fix iwlwifi on old cards in v4.19 was Re: 4.19-rc[23] iwlwifi: BUG in swiotlb

From: Randy Dunlap
Date: Sun Sep 16 2018 - 18:27:36 EST


On 9/16/18 2:59 AM, Pavel Machek wrote:
>
> .max_tfd_queue_size was ommited for old cards, leading to oops in
> swiotlb.
>
> Signed-off-by: Pavel Machek <pavel@xxxxxx>
>

Hi,
Thanks. Works for me.

Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>


PS: I started the b-word yesterday but my old laptop is slow...


> --- linux/drivers/net/wireless/intel/iwlwifi/cfg/1000.c 2018-09-05 13:12:40.453164067 +0200
> +++ linux-64/drivers/net/wireless/intel/iwlwifi/cfg/1000.c 2018-09-16 11:54:04.010970756 +0200
> @@ -51,6 +51,7 @@
>
> static const struct iwl_base_params iwl1000_base_params = {
> .num_of_queues = IWLAGN_NUM_QUEUES,
> + .max_tfd_queue_size = 256,
> .eeprom_size = OTP_LOW_IMAGE_SIZE,
> .pll_cfg = true,
> .max_ll_items = OTP_MAX_LL_ITEMS_1000,
>
>


--
~Randy