Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested

From: Greg KH
Date: Mon Sep 17 2018 - 10:28:35 EST


On Mon, Sep 17, 2018 at 02:16:48PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Sunday, September 16, 2018 9:56 PM
> > To: KY Srinivasan <kys@xxxxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> > olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; Stephen
> > Hemminger <sthemmin@xxxxxxxxxxxxx>; Michael Kelley (EOSG)
> > <Michael.H.Kelley@xxxxxxxxxxxxx>; vkuznets <vkuznets@xxxxxxxxxx>
> > Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
> > operation was requested
> >
> > On Mon, Sep 17, 2018 at 04:14:55AM +0000, kys@xxxxxxxxxxxxxxxxx wrote:
> > > From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> > >
> > > 'error' variable is left uninitialized in case we see an unknown operation.
> > > As we don't immediately return and proceed to pwrite() we need to set it
> > > to something, HV_E_FAIL sounds good enough.
> > >
> > > Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > > ---
> > > tools/hv/hv_fcopy_daemon.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > No need to backport for stable?
> Thanks for pointing this out. Should I resubmit with the stable tag?

I can do it... :)