Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

From: Andy Lutomirski
Date: Mon Sep 17 2018 - 12:18:38 EST




> On Sep 17, 2018, at 9:16 AM, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
>> On Mon, Sep 17, 2018 at 6:14 PM Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
>> Indeed. What I'm saying is that you shouldn't refactor it this way
>> because it will be slow. I agree it would be conceptually nice to be
>> able to blacklist a chacha20_x86_64 module to disable the asm, but I
>> think it would be very hard to get good performance.
>
> I hadn't understood your nosimd=1 command line suggestion the first
> time through, but now I see what you were after. This would be really
> easy to add. And I can do it for v5 if you want. But I'm kind of loath
> to add too much stuff to the initial patchset. Do you think this is an
> important feature to have for it? Or should I leave it for later?

I think itâs fine for later. Itâs potentially useful for benchmarking and debugging.