Re: [PATCH 2/6] pstore: Add event tracing support

[Sai Prakash Ranjan]

On 9/17/2018 8:24 PM, Kees Cook wrote:
> On Sun, Sep 16, 2018 at 6:55 AM, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:
> > On Sun, Sep 16, 2018, 12:08 AM Sai Prakash Ranjan
> > <saiprakash.ranjan@xxxxxxxxxxxxxx> wrote:
> > > On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote:
> > > > Currently pstore has function trace support which can be
> > > > used to get the function call chain with limited data.
> > > > Event tracing has extra data which is useful to debug wide
> > > > variety of issues and is heavily used across the kernel.
> > > >
> > > > Adding this support to pstore can be very helpful to debug
> > > > different subsystems since almost all of them have trace
> > > > events already available. And also it is useful to debug
> > > > unknown resets or crashes since we can get lot more info
> > > > from event tracing by viewing the last occurred events.
> > >
> > > Anyone here?
> >
> > Sorry for the top post. I've been wanting to do this as well for some time.
> > It's quite useful. I am out of office this week and away from work machine.
> > I will take a look at your patches next week once I'm back at work. Thanks.
>
> If Steven agrees this shouldn't live in ftrace directly and Joel
> reviews these patches, I think it should be fine. I'm travelling, but
> I can review it hopefully later this week.

Thank you Kees.

- Sai