Re: [PATCHv2 2/2] scsi: ibmvscsis: Ensure partition name is properly NUL terminated

From: Bryant Ly
Date: Mon Sep 17 2018 - 21:38:23 EST




> On Sep 11, 2018, at 2:22 PM, Laura Abbott <labbott@xxxxxxxxxx> wrote:
>
> While reviewing another part of the code, Kees noticed that the
> strncpy of the partition name might not always be NUL terminated. Switch
> to using strscpy which does this safely.
>
> Reported-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> v2: Switch to strscpy instead of just strlcpy
> ---
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bryant G. Ly bly@xxxxxxxxxxxxxxxxxxxxx

I sent a PR to update my email from bryantly@xxxxxxxxxxxxxxxxxx a week ago.

-Bryant