Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage

From: David Miller
Date: Mon Sep 17 2018 - 22:35:36 EST


From: Al Stone <ahs3@xxxxxxxxxx>
Date: Mon, 17 Sep 2018 17:35:33 -0600

> @@ -866,8 +866,11 @@ static int xgene_enet_napi(struct napi_struct *napi, const int budget)
> processed = xgene_enet_process_ring(ring, budget);
>
> if (processed != budget) {
> + struct irq_desc *desc = irq_to_desc(ring->irq);
> +
> napi_complete_done(napi, processed);
> - enable_irq(ring->irq);
> + if (desc && desc->depth > 0)
> + enable_irq(ring->irq);

I really can't accept a patch that grovels into IRQ layer internals
to work around a driver's IRQ enable/disable usage problem.

Sorry.