Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

From: Greg Kroah-Hartman
Date: Tue Sep 18 2018 - 07:19:59 EST


On Fri, Sep 14, 2018 at 10:40:22PM +0800, Gao Xiang wrote:
> In order to avoid conflicts with cleanup patches, Chao and I think
> it is better to send reviewed preview patches in the erofs mailing list
> to the community in time.
>
> So here is reviewed & tested patches right now, which clean up and
> enhance the error handing and add some tracepoints for decompression.
>
> Note that in this patchset, bare use of 'unsigned' and NULL comparison are
> also fixed compared with the preview patches according to the previous
> discussion in the staging mailing list.

I applied this, but I need to go delete it as this patch series adds a
build warning to the system:

In file included from drivers/staging/erofs/unzip_vle.h:16:0,
from drivers/staging/erofs/unzip_vle.c:13:
drivers/staging/erofs/unzip_vle.c: In function âz_erofs_map_blocks_iterâ:
drivers/staging/erofs/internal.h:303:34: warning: âpblkâ may be used uninitialized in this function [-Wmaybe-uninitialized]
#define blknr_to_addr(nr) ((erofs_off_t)(nr) * EROFS_BLKSIZ)
^
drivers/staging/erofs/unzip_vle.c:1574:20: note: âpblkâ was declared here
erofs_blk_t mblk, pblk;
^~~~

Please fix that up and resend.

thanks,

greg k-h