Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage

[Eric Dumazet]

On 09/18/2018 04:27 PM, Eric Dumazet wrote:
> 

> I remember one of the napi_complete_done() change had to be reverted,
> for some obscure reason.



That was not exactly a revert,  :

commit 129c6cda2de2a8ac44fab096152469999b727faf
Author: Eric Dumazet <edumazet@xxxxxxxxxx>
Date:   Mon Sep 18 13:03:43 2017 -0700

    8139too: revisit napi_complete_done() usage
    
    It seems we have to be more careful in napi_complete_done()
    use. This patch is not a revert, as it seems we can
    avoid bug that Ville reported by moving the napi_complete_done()
    test in the spinlock section.
    
    Many thanks to Ville for detective work and all tests.
    
    Fixes: 617f01211baf ("8139too: use napi_complete_done()")
    Reported-by: Ville SyrjÃlà <ville.syrjala@xxxxxxxxxxxxxxx>
    Tested-by: Ville SyrjÃlà <ville.syrjala@xxxxxxxxxxxxxxx>
    
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>