Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line

[He Zhe]

On 2018å09æ19æ 09:50, Sergey Senozhatsky wrote:
> On (09/19/18 01:17), zhe.he@xxxxxxxxxxxxx wrote:
>> @@ -1048,7 +1048,14 @@ static void __init log_buf_len_update(unsigned size)
>>  /* save requested log_buf_len since it's too early to process it */
>>  static int __init log_buf_len_setup(char *str)
>>  {
>> -	unsigned size = memparse(str, &str);
>> +	unsigned size;
> 	unsigned int size;

This is in v1 but then Steven suggested that it should be split out
and only keep the pure fix part here.

>
>> +	if (!str) {
>> +		pr_err("Config string not provided\n");
> pr_debug() may be?
>
> It's not clear from this error message which one of the "config strings"
> was not provided. Besides, I think "config string" is misleading and in
> fact it's a "boot command line parameter". But, dunno, I guess I'd just
> drop that print out.

I'm OK with dropping it. Anyway it'd get "Malformed early
option 'log_buf_len'" from early_param later.

I'll send v3. Thank you.

Zhe

>
> Otherwise,
>
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>
> 	-ss
>