Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line

From: He Zhe
Date: Wed Sep 19 2018 - 06:09:45 EST




On 2018å09æ19æ 14:44, Sergey Senozhatsky wrote:
> On (09/19/18 10:27), He Zhe wrote:
>> On 2018å09æ19æ 09:50, Sergey Senozhatsky wrote:
>>> On (09/19/18 01:17), zhe.he@xxxxxxxxxxxxx wrote:
>>>> @@ -1048,7 +1048,14 @@ static void __init log_buf_len_update(unsigned size)
>>>> /* save requested log_buf_len since it's too early to process it */
>>>> static int __init log_buf_len_setup(char *str)
>>>> {
>>>> - unsigned size = memparse(str, &str);
>>>> + unsigned size;
>>> unsigned int size;
>> This is in v1 but then Steven suggested that it should be split out
>> and only keep the pure fix part here.
> JFI
>
> Seems there are more patches like this. I found this one in MM list:
> lkml.kernel.org/r/1537284788-428784-1-git-send-email-zhe.he@xxxxxxxxxxxxx
>
> Andrew's response:
> lkml.kernel.org/r/20180918141917.2cb16b01c122dbe1ead2f657@xxxxxxxxxxxxxxxxxxxx

I just replied. Let's see what Andrew would say.
https://lore.kernel.org/lkml/1c32c1d2-a54a-30f7-1afb-ad6d3282f54a@xxxxxxxxxxxxx/

Thanks,
Zhe

>
> -ss
>