Re: [PATCH] tools: Remove conflicting BITS_PER_LONG define

From: Alexander Sverdlin
Date: Wed Sep 19 2018 - 08:17:05 EST


On 12/09/2018 21:01, Arnaldo Carvalho de Melo wrote:
>> CC .../tools/objtool/builtin-check.o
>> ...
>> In file included from .../tools/arch/x86/include/uapi/asm/bitsperlong.h:11:0,
>> from .../tools/include/asm-generic/bitops/__ffs.h:6,
>> from .../tools/include/asm-generic/bitops.h:16,
>> from .../tools/include/linux/bitops.h:35,
>> from .../tools/include/linux/hashtable.h:13,
>> from elf.h:24,
>> from check.h:22,
>> from builtin-check.c:30:
>> .../tools/include/asm-generic/bitsperlong.h:8:0: error: "BITS_PER_LONG" redefined [-Werror]
>> #define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
>>
>> Include <asm/bitsperlong.h> instead as other headers do.
> Please try test building all tools in tools/
>
> This broke make -C tools/perf/

I agree, this brakes perf, so we need to work further on that...

--
Best regards,
Alexander Sverdlin.