Re: [PATCH v3 05/20] tpm: factor out tpm_get_timeouts

From: Jarkko Sakkinen
Date: Wed Sep 19 2018 - 10:04:35 EST

Next message: Jarkko Sakkinen: "Re: [PATCH v3 06/20] tpm: move tpm1_pcr_extend to tpm1-cmd.c"
Previous message: Jarkko Sakkinen: "Re: [PATCH v3 04/20] tpm: add tpm_calc_ordinal_duration wrapper"
In reply to: Tomas Winkler: "[PATCH v3 05/20] tpm: factor out tpm_get_timeouts"
Next in thread: Tomas Winkler: "[PATCH v3 09/20] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Sep 18, 2018 at 12:34:44PM +0300, Tomas Winkler wrote:
> Factor out tpm_get_timeouts into tpm2_get_timeouts
> and tpm1_get_timeouts.

Function names missing parentheses. Should be there for clarity when
used in a sentence. Otherwise, the commit looks fine.

Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

/Jarkko

Next message: Jarkko Sakkinen: "Re: [PATCH v3 06/20] tpm: move tpm1_pcr_extend to tpm1-cmd.c"
Previous message: Jarkko Sakkinen: "Re: [PATCH v3 04/20] tpm: add tpm_calc_ordinal_duration wrapper"
In reply to: Tomas Winkler: "[PATCH v3 05/20] tpm: factor out tpm_get_timeouts"
Next in thread: Tomas Winkler: "[PATCH v3 09/20] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]