Re: [PATCH v3 07/20] tpm: move tpm_getcap to tpm1-cmd.c

[Jarkko Sakkinen]

On Tue, Sep 18, 2018 at 12:34:46PM +0300, Tomas Winkler wrote:
> 1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap.
> 2. Remove unused tpm_getcap_header with unused constant
> as this functionality is already implemented using tpm_buf construct.
> 
> Fixes warning:
> drivers/char/tpm/tpm-interface.c:452:38: warning: âtpm_getcap_headerâ defined but not used [-Wunused-const-variable=]
>  static const struct tpm_input_header tpm_getcap_header = {
>                                       ^~~~~~~~~~~~~~~~~
> 3. Drop unused TPM_DIGEST_SIZE. It's already defined in
> include/linux/tpm.h

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

/Jarkko