Re: [PATCH v3 1/2] dt-bindings: power: Add Spreadtrum SC2731 charger documentation

From: Sebastian Reichel
Date: Wed Sep 19 2018 - 21:02:22 EST


Hi,

On Mon, Sep 17, 2018 at 01:03:30PM -0700, Baolin Wang wrote:
> This patch adds the binding documentation for Spreadtrum SC2731 charger
> device.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---

Thanks, queued.

-- Sebastian

> Changes from v2:
> - Add reviewed tag from Krzysztof.
>
> Changes from v1:
> - Add parent node.
> - Add some battery standard properties.
> ---
> .../bindings/power/supply/sc2731_charger.txt | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/sc2731_charger.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sc2731_charger.txt b/Documentation/devicetree/bindings/power/supply/sc2731_charger.txt
> new file mode 100644
> index 0000000..5266fab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/sc2731_charger.txt
> @@ -0,0 +1,40 @@
> +Spreadtrum SC2731 PMIC battery charger binding
> +
> +Required properties:
> + - compatible: Should be "sprd,sc2731-charger".
> + - reg: Address offset of charger register.
> + - phys: Contains a phandle to the USB phy.
> +
> +Optional Properties:
> +- monitored-battery: phandle of battery characteristics devicetree node.
> + The charger uses the following battery properties:
> +- charge-term-current-microamp: current for charge termination phase.
> +- constant-charge-voltage-max-microvolt: maximum constant input voltage.
> + See Documentation/devicetree/bindings/power/supply/battery.txt
> +
> +Example:
> +
> + bat: battery {
> + compatible = "simple-battery";
> + charge-term-current-microamp = <120000>;
> + constant-charge-voltage-max-microvolt = <4350000>;
> + ......
> + };
> +
> + sc2731_pmic: pmic@0 {
> + compatible = "sprd,sc2731";
> + reg = <0>;
> + spi-max-frequency = <26000000>;
> + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + charger@0 {
> + compatible = "sprd,sc2731-charger";
> + reg = <0x0>;
> + phys = <&ssphy>;
> + monitored-battery = <&bat>;
> + };
> + };
> --
> 1.9.1
>

Attachment: signature.asc
Description: PGP signature