Re: [PATCH 1/3 v2] resource: fix an error which walks through iomem resources

From: Dave Young
Date: Thu Sep 20 2018 - 02:59:48 EST


On 09/20/18 at 02:39pm, lijiang wrote:
> å 2018å09æ19æ 21:29, Borislav Petkov åé:
> > On Wed, Sep 19, 2018 at 08:52:49PM +0800, Lianbo Jiang wrote:
> >
> > ...
> >
> >> In fact, we should get the resource A and B when we walk through the
> >> whole tree, but it only gets the resource A, the resource B is missed.
> >>
> >> Signed-off-by: Dave Young <dyoung@xxxxxxxxxx>
> >> Signed-off-by: Lianbo Jiang <lijiang@xxxxxxxxxx>
> >
> > Before looking at this: the SOB chain of all three patches is wrong.
> > Hint: see section 12) in Documentation/process/submitting-patches.rst
> >
> Thanks for your advice, Borislav.
>
> I have discussed with Dave Young, and he suggested that i might add a Suggested-by

patch 2 and patch 3 are based on my draft patch, but since you did debugging
and changes you can move my SOB to Suggested-by for patch 2 and patch 3,
for patch 1 please just drop my SOB and leave yours only.


> tag instead of Signed-off-by tag for him. What do you think about?
>
> I will modify the invalid SOB chain and post it again.
>

Thanks
Dave