Re: [EXT] [PATCH net] net: mvneta: fix the Rx desc buffer DMA unmapping
From: Antoine Tenart
Date: Thu Sep 20 2018 - 07:20:14 EST
On Thu, Sep 20, 2018 at 10:14:56AM +0000, Yelena Krivosheev wrote:
> Please, check and fix all cases of dma_unmap_single() usage.
> See mvneta_rxq_drop_pkts()
> if (!data || !(rx_desc->buf_phys_addr))
> dma_unmap_single(pp->dev->dev.parent, rx_desc->buf_phys_addr,
> MVNETA_RX_BUF_SIZE(pp->pkt_size), DMA_FROM_DEVICE);
I had a look at the one reported by CONFIG_DMA_API_DEBUG, and at DMA
unmapping calls using PAGE_SIZE. As you pointed out there might be
others parts, thanks!
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering