Re: [PATCH] gpiolib: Show correct direction from the beginning

From: Timur Tabi
Date: Thu Sep 20 2018 - 08:35:57 EST


On 9/20/18 12:23 AM, Linus Walleij wrote:
I think most gpiochips easily survives calling the .get_direction()
early, Qualcomm's stand out here.

Now that we have .valid_mask in the gpiochip could we simply just
add this back, resepecting valid_mask and avoid checking the
direction of precisely these GPIOs?

Can you be more specific? One of the proposals made previously was to add a check in msm_gpio_get_direction(), but that was rejected because the consensus was the valid_mask checks in gpiolib are sufficient.