Re: [PATCH v2] usb: host: Replace empty define with do while

From: Alan Stern
Date: Thu Sep 20 2018 - 10:24:26 EST


On Wed, 19 Sep 2018, Corentin Labbe wrote:

> It's dangerous to use empty code define.
> Furthermore it lead to the following warning:
> "suggest braces around empty body in an ÂÂelseÂÂ statement"
>
> So let's replace emptyness by "do {} while(0)"
>
> Furthermore, as suggested by Joe Perches, rename the macro to INCR.
>
> Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> ---
> Changes since v1:
> - rename the macro from COUNT to INCR

For the EHCI portions:

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>