Re: [PATCH] Don't hardcode path as it is architecture dependent

From: Richard Weinberger
Date: Thu Sep 20 2018 - 15:05:34 EST


Am Donnerstag, 20. September 2018, 08:26:38 CEST schrieb Ritesh Raj Sarraf:
> The current code fails to run on amd64 because of hardcoded reference to
> i386
>
> Signed-off-by: Ritesh Raj Sarraf <rrs@xxxxxxxxxxxxxx>

Thanks for spotting this!

> ---
> arch/um/drivers/port_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c
> index 9a8e1b64c22e..5f56d11b886f 100644
> --- a/arch/um/drivers/port_user.c
> +++ b/arch/um/drivers/port_user.c
> @@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out)
> {
> int new, err;
> char *argv[] = { "/usr/sbin/in.telnetd", "-L",
> - "/usr/lib/uml/port-helper", NULL };
> + OS_LIB_PATH "/uml/port-helper", NULL };
> struct port_pre_exec_data data;
>
> new = accept(fd, NULL, 0);

Thanks,
//richard