[PATCH 44/44] coresight: Remove redundant null pointer check before of_node_put and put_device
From: Mathieu Poirier
Date: Thu Sep 20 2018 - 15:19:33 EST
From: zhong jiang <zhongjiang@xxxxxxxxxx>
of_node_put and put_device has taken the null pointer check into account.
So it is safe to remove the duplicated check.
Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
---
drivers/hwtracing/coresight/of_coresight.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index da71c975e3f7..89092f83567e 100644
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c
@@ -219,12 +219,9 @@ static int of_coresight_parse_endpoint(struct device *dev,
ret = 1;
} while (0);
- if (rparent)
- of_node_put(rparent);
- if (rep)
- of_node_put(rep);
- if (rdev)
- put_device(rdev);
+ of_node_put(rparent);
+ of_node_put(rep);
+ put_device(rdev);
return ret;
}
--
2.7.4