Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

From: YueHaibing
Date: Thu Sep 20 2018 - 21:33:36 EST


On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>

Yes, I will send it separately after test and review again.

Thank you for your advice.

> .
>