Re: [PATCH] lib/xz: Fix powerpc build with KERNEL_XZ

From: Joel Stanley
Date: Thu Sep 20 2018 - 22:30:51 EST


On Wed, 19 Sep 2018 at 16:09, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Wed, 19 Sep 2018 at 01:08, Joel Stanley <joel@xxxxxxxxx> wrote:
> >
> > This partially reverts faa16bc404d72a5 ("lib: Use existing define with
> > polynomial").
> >
> > The cleanup added a dependency on include/linux, which broke the PowerPC
> > boot wrapper/decompresser when KERNEL_XZ is enabled:
> >
> > BOOTCC arch/powerpc/boot/decompress.o
> > In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:233,
> > from arch/powerpc/boot/decompress.c:42:
> > arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:10: fatal error:
> > linux/crc32poly.h: No such file or directory
> > #include <linux/crc32poly.h>
> > ^~~~~~~~~~~~~~~~~~~
> >
> > The powerpc decompressor is a hairy corner of the kernel. Even while building
> > a 64-bit kernel it needs to build a 32-bit binary and therefore avoid including
> > files from include/linux.
>
> I fixed the build error here:
> https://lkml.org/lkml/2018/8/29/179
>
> If you choose to remove any includes from /linux, then go ahead but
> please use original reported-by :)

Okay. I'll try Christophe's suggestion instead.

Cheers,

Joel