Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops
From: Takashi Iwai
Date: Fri Sep 21 2018 - 05:23:51 EST
On Fri, 21 Sep 2018 11:21:35 +0200,
Nick Simonov wrote:
>
> On Fri, Sep 21, 2018 at 08:51:51AM +0200, Takashi Iwai wrote:
> > On Fri, 21 Sep 2018 07:47:38 +0200,
> > Nick Simonov wrote:
> > >
> > > snd_pcm_ops are not supposed to change. So mark the
> > > non-const structs as const. Also, refine indentation
> > > to increase readability.
> > >
> > > Signed-off-by: Nick Simonov <nicksimonovv@xxxxxxxxx>
> > > ---
> > > Changes v2:
> > > - Fix typo in commit description, ncrease to increase.
> >
> > Since I already merged your first version, please resubmit as an
> > incremental patch. At best, check the latest linux-next or my
> > sound.git tree for-next branch, and create a patch on its top.
> >
> >
> > thanks,
> >
> > Takashi
>
> Sorry I want to clarify, there is no mistakes in the code itself
> there is a typo in commit message. As I now there is no way to change
> commit message without rebase after merge, so which is the proper way in
> this case? leave it as is?
Then let's leave as is.
thanks,
Takashi