Re: [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory

From: Christoph Hellwig
Date: Fri Sep 21 2018 - 12:05:35 EST


On Fri, Sep 21, 2018 at 09:37:33AM -0600, Logan Gunthorpe wrote:
> On 2018-09-21 7:00 AM, Bjorn Helgaas wrote:
> > On Thu, Sep 20, 2018 at 04:47:49PM -0600, Logan Gunthorpe wrote:
> >> On 2018-09-20 4:38 PM, Bjorn Helgaas wrote:
> >>>> +#define pr_fmt(fmt) "pci-p2pdma: " fmt
> >>>
> >>> Is pr_fmt() actually used anywhere?
> >>
> >> It's used in a Patch 4 to print errors in the configfs helpers.
> >
> > Ideally pr_fmt() would be added in the same patch that uses it, but
> > obviously pretty trivial.
>
> Hmm, well Christoph asked me to do it this way. ;)

Sorry. I somehow was under the impression we already had a printk
in the earlier patch, but it looks like I was confused.