Re: [PATCH RFC 3/3] Documentation: RCU: Fix rcu_preempt_state reference in stallwarn
From: Paul E. McKenney
Date: Sat Sep 22 2018 - 20:37:36 EST
On Sat, Sep 22, 2018 at 07:41:27PM -0400, Joel Fernandes (Google) wrote:
> rcu_preempt_state doesn't exist anymore. Update stallwarn documentation
> accordingly.
>
> Signed-off-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>
Good eyes, queued and pushed with edits, including fixing a grammar
nit in my original. ;-)
Thanx, Paul
> ---
> Documentation/RCU/stallwarn.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/RCU/stallwarn.txt b/Documentation/RCU/stallwarn.txt
> index 491043fd976f..b6bc7a2a9961 100644
> --- a/Documentation/RCU/stallwarn.txt
> +++ b/Documentation/RCU/stallwarn.txt
> @@ -176,9 +176,8 @@ causing stalls, and that the stall was affecting RCU-sched. This message
> will normally be followed by stack dumps for each CPU. Please note that
> PREEMPT_RCU builds can be stalled by tasks as well as by CPUs, and that
> the tasks will be indicated by PID, for example, "P3421". It is even
> -possible for a rcu_preempt_state stall to be caused by both CPUs -and-
> -tasks, in which case the offending CPUs and tasks will all be called
> -out in the list.
> +possible for a rcu_state stall to be caused by both CPUs -and- tasks,
> +in which case the offending CPUs and tasks will all be called out in the list.
>
> CPU 2's "(3 GPs behind)" indicates that this CPU has not interacted with
> the RCU core for the past three grace periods. In contrast, CPU 16's "(0
> --
> 2.19.0.444.g18242da7ef-goog
>