Re: [PATCH crypto-next 18/23] crypto: artpec6 - Remove VLA usage of skcipher

From: Lars Persson
Date: Sun Sep 23 2018 - 08:13:59 EST




On 9/19/18 4:10 AM, Kees Cook wrote:
In the quest to remove all stack VLA usage from the kernel[1], this
replaces struct crypto_skcipher and SKCIPHER_REQUEST_ON_STACK() usage
with struct crypto_sync_skcipher and SYNC_SKCIPHER_REQUEST_ON_STACK(),
which uses a fixed stack size.

[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@xxxxxxxxxxxxxx

Cc: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
Cc: Lars Persson <lars.persson@xxxxxxxx>
Cc: linux-arm-kernel@xxxxxxxx
Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
---
drivers/crypto/axis/artpec6_crypto.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)


Acked-by: Lars Persson <lars.persson@xxxxxxxx>