[PATCH] perf tools: Do not zero sample_id_all for group members

From: Jiri Olsa
Date: Sun Sep 23 2018 - 11:04:26 EST


Andi reported following malfunction:

# perf record -e '{ref-cycles,cycles}:S' -a sleep 1
# perf script
non matching sample_id_all

That's because we disable sample_id_all bit for non-sampling
group members. We can't do that, because it needs to be the
same over the whole event list. This patch keeps it untouched
again.

Fixes: e9add8bac6c6 ("perf evsel: Disable write_backward for leader sampling group events")
Reported-by: Andi Kleen <andi@xxxxxxxxxxxxxx>
Link: http://lkml.kernel.org/n/tip-y7hc1i6en4saxqxuwr2g24f1@xxxxxxxxxxxxxx
Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
---
tools/perf/tests/attr/test-record-group-sampling | 1 -
tools/perf/util/evsel.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/tools/perf/tests/attr/test-record-group-sampling b/tools/perf/tests/attr/test-record-group-sampling
index 8a33ca4f9e1f..f0729c454f16 100644
--- a/tools/perf/tests/attr/test-record-group-sampling
+++ b/tools/perf/tests/attr/test-record-group-sampling
@@ -37,4 +37,3 @@ sample_freq=0
sample_period=0
freq=0
write_backward=0
-sample_id_all=0
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index cb7f01059940..ff5313b70cb5 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -952,7 +952,6 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts,
attr->sample_freq = 0;
attr->sample_period = 0;
attr->write_backward = 0;
- attr->sample_id_all = 0;
}

if (opts->no_samples)
--
2.17.1