Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

[Rohit Kumar]

On 9/24/2018 12:19 PM, Rohit Kumar wrote:
> Thanks Sibi for reviewing.
>
>
> On 9/22/2018 1:11 AM, Sibi Sankar wrote:
> > Hi Rohit,
> >
> > On 2018-09-03 17:22, Rohit kumar wrote:
> > > This adds Non PAS ADSP PIL driver for Qualcomm
> > > Technologies Inc SoCs.
> > > Added initial support for SDM845 with ADSP bootup and
> > > shutdown operation handled from Application Processor
> > > SubSystem(APSS).
> > >
> > > Signed-off-by: Rohit kumar <rohitkr@xxxxxxxxxxxxxx>
> > > ---
> > ....
...
> > ....
> > Also I see the following warns on stopping the adsp remoteproc, 
> > couldn't root cause it though:
>
> It should be issue in Q6 drivers. I will check and update q6 drivers. 
> Thanks for reporting.

Checked this warning. This is a core driver issue fixed with 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/base/core.c?h=next-20180924&id=2ec16150179888b81717d1d3ce84e634f4736af2 

> > Âdevice_del+0x84/0x29c
> > Âplatform_device_del+0x2c/0x88
> > Âplatform_device_unregister+0x1c/0x30
> > Âof_platform_device_destroy+0x98/0xa8
> > Âdevice_for_each_child+0x54/0xa4
> > Âof_platform_depopulate+0x38/0x54
> > Âq6asm_remove+0x1c/0x2c
> > Âapr_device_remove+0x38/0x70
> > Âdevice_release_driver_internal+0x124/0x1c8
> > Âdevice_release_driver+0x24/0x30
> > Âbus_remove_device+0xcc/0xe4
> > Âdevice_del+0x1f8/0x29c
> > Âdevice_unregister+0x1c/0x30
> > Âapr_remove_device+0x1c/0x2c
> > Âdevice_for_each_child+0x54/0xa4
> > Âapr_remove+0x28/0x34
> > Ârpmsg_dev_remove+0x48/0x70
> > Âdevice_release_driver_internal+0x124/0x1c8
> > Âdevice_release_driver+0x24/0x30
> > Âbus_remove_device+0xcc/0xe4
> > Âdevice_del+0x1f8/0x29c
> > Âdevice_unregister+0x1c/0x30
> > Âqcom_glink_remove_device+0x1c/0x2c
> > Âdevice_for_each_child+0x54/0xa4
> > Âqcom_glink_native_remove+0x54/0x15c
> > Âqcom_glink_smem_unregister+0x1c/0x30
> > Âglink_subdev_stop+0x1c/0x2c [qcom_common]
> > Ârproc_stop+0x40/0xc0
> > Ârproc_shutdown+0x6c/0xc0
> > Ârproc_del+0x28/0xa0
> > Âadsp_remove+0x20/0x5c [qcom_adsp_pil]
> > Âplatform_drv_remove+0x28/0x50
> > Âdevice_release_driver_internal+0x124/0x1c8
> > Âdriver_detach+0x44/0x80
> > Âbus_remove_driver+0x78/0x9c
> > Âdriver_unregister+0x34/0x54
> > Âplatform_driver_unregister+0x1c/0x28
> > Âcleanup_module+0x14/0x6bc [qcom_adsp_pil]
> > ÂSyS_delete_module+0x1c4/0x214
>
> Thanks,
> Rohit
Thanks