Re: [PATCH v2 4/5] m68k: uapi header and system call table file generation

[Firoz Khan]

On Mon, 24 Sep 2018 at 12:35, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Firoz,
>
> On Thu, Sep 20, 2018 at 5:07 PM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
> > System call table generation script must be run to generate
> > unistd_32.h and syscall_table.h files. This patch will have
> > changes which will invokes the script.
> >
> > This patch will generate unistd_32.h and syscall_table.h
> > files by the syscall table generation script invoked by
> > arch/m68k/Makefile and the generated files against the
> > removed files will be identical.
> >
> > The generated uapi header file will be included in
> > uapi/asm/unistd.h and generated system call table support
> > file will be included by arch/m68k/kernel/syscall_table.S
> > file.
> >
> > Signed-off-by: Firoz Khan <firoz.khan@xxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/m68k/include/asm/Kbuild
> > +++ b/arch/m68k/include/asm/Kbuild
> > @@ -24,3 +24,4 @@ generic-y += topology.h
> >  generic-y += trace_clock.h
> >  generic-y += word-at-a-time.h
> >  generic-y += xor.h
> > +generic-y += syscall_table.h
> > \ No newline at end of file
>
> Please add the missing newline.

Sure. Will do. Thanks!

>
> > diff --git a/arch/m68k/include/uapi/asm/Kbuild b/arch/m68k/include/uapi/asm/Kbuild
> > index c2e26a4..6d600e9 100644
> > --- a/arch/m68k/include/uapi/asm/Kbuild
> > +++ b/arch/m68k/include/uapi/asm/Kbuild
> > @@ -21,3 +21,4 @@ generic-y += statfs.h
> >  generic-y += termbits.h
> >  generic-y += termios.h
> >  generic-y += types.h
> > +generic-y += unistd_32.h
> > \ No newline at end of file
>
> Likewise.
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds