Re: [PATCH v2 2/2] mm/page_alloc: Add KBUILD_MODNAME

From: Michal Hocko
Date: Mon Sep 24 2018 - 10:26:13 EST


On Sat 22-09-18 22:53:33, zhe.he@xxxxxxxxxxxxx wrote:
> From: He Zhe <zhe.he@xxxxxxxxxxxxx>
>
> Add KBUILD_MODNAME to make prints more clear.

Please be more explicit. Examples of before and after would be really
helpful.

> Signed-off-by: He Zhe <zhe.he@xxxxxxxxxxxxx>
> Cc: akpm@xxxxxxxxxxxxxxxxxxxx
> Cc: mhocko@xxxxxxxx
> Cc: vbabka@xxxxxxx
> Cc: pasha.tatashin@xxxxxxxxxx
> Cc: mgorman@xxxxxxxxxxxxxxxxxxx
> Cc: aaron.lu@xxxxxxxxx
> Cc: osalvador@xxxxxxx
> Cc: iamjoonsoo.kim@xxxxxxx
> ---
> v2:
> Split the addition of KBUILD_MODNAME out
>
> mm/page_alloc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f34cae1..ead9556 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -14,6 +14,8 @@
> * (lots of bits borrowed from Ingo Molnar & Andrew Morton)
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> #include <linux/stddef.h>
> #include <linux/mm.h>
> #include <linux/swap.h>
> --
> 2.7.4
>

--
Michal Hocko
SUSE Labs