Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

[Joe Perches]

On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote:
> 3.18-stable review patch.  If anyone has any objections, please let me know.

Why should this sort of change be applied to a stable release?

> ------------------
> 
> From: Bart Van Assche <bart.vanassche@xxxxxxx>
> 
> [ Upstream commit 4c5743bc4fe3233cecc1c184a773c79c8ee45bbe ]
> 
> Avoid that the following compiler warning is reported when building with
> W=1:
> 
> drivers/infiniband/hw/nes/nes_hw.c:646:51: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/nes/nes.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> It'
> --- a/drivers/infiniband/hw/nes/nes.h
> +++ b/drivers/infiniband/hw/nes/nes.h
> @@ -156,7 +156,7 @@ do { \
>  
>  #define NES_EVENT_TIMEOUT   1200000
>  #else
> -#define nes_debug(level, fmt, args...)
> +#define nes_debug(level, fmt, args...) do {} while (0)
>  #define assert(expr)          do {} while (0)
>  
>  #define NES_EVENT_TIMEOUT   100000
> 
>