Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

From: Greg Kroah-Hartman
Date: Mon Sep 24 2018 - 14:40:16 EST


On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote:
> On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote:
> > > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote:
> > > > 3.18-stable review patch. If anyone has any objections, please let me know.
> > >
> > > Why should this sort of change be applied to a stable release?
> >
> > Originally I was just going to drop this as it's not fixing something.
> >
> > But it might be, if that macro is used in a if() statement, or something
> > like that, it could be doing something unintended.
>
> No it couldn't.
> An empty macro is equivalent to a single statement.

{sigh} It's been a long few weeks...

Yes, you are right, I was forgetting the trailing ;

Ok, I'll go drop this now, thanks.

greg k-h