Re: [PATCH V7 2/2] csky: remove irq_mapping from smp.c.

[Arnd Bergmann]

On Tue, Sep 18, 2018 at 3:48 PM Guo Ren <ren_guo@xxxxxxxxx> wrote:
>
>  - remove irq_mapping from smp.c to irq-driver
>  - Add set_ipi_irq_mapping api to irq-driver
>  - update asm/smp.h
>
> Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx>

The patch seems ok to me, but please try to improve the changelog comments.
Generally speaking, use full English sentences instead of an enumerated list,
and explain what the change is for rather than what you are doing. The text
you have here can easily be derived from looking at the code changes,
but I still don't understand what caused you to change it, and why this
is better than the previous version.

       Arnd