Re: [PATCH v3 1/2] printk: Fix panic caused by passing log_buf_len to command line

From: Sergey Senozhatsky
Date: Tue Sep 25 2018 - 07:38:46 EST


On (09/22/18 23:40), zhe.he@xxxxxxxxxxxxx wrote:
> @@ -1048,7 +1048,14 @@ static void __init log_buf_len_update(unsigned size)
> /* save requested log_buf_len since it's too early to process it */
> static int __init log_buf_len_setup(char *str)
> {
> - unsigned size = memparse(str, &str);
> + unsigned int size;
> +
> + if (!str) {
> + pr_err("boot command line parameter value not provided\n");
> + return -EINVAL;
> + }

Hmm, I thought we agreed on dropping this error print out. It's not exactly
useful; we still have the default buffer size.

-ss