Re: [PATCH v7 10/13] nvme-pci: Add support for P2P memory in requests

From: Keith Busch
Date: Tue Sep 25 2018 - 13:09:46 EST


On Tue, Sep 25, 2018 at 10:22:28AM -0600, Logan Gunthorpe wrote:
> For P2P requests, we must use the pci_p2pmem_map_sg() function
> instead of the dma_map_sg functions.

Sorry if this was already discussed. Is there a reason the following
pattern is not pushed to the generic dma_map_sg_attrs?

if (is_pci_p2pdma_page(sg_page(sg)))
pci_p2pdma_map_sg(dev, sg, nents, dma_dir);

Beyond that, series looks good.