Re: [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit()

From: Palmer Dabbelt
Date: Tue Sep 25 2018 - 13:19:29 EST


On Tue, 25 Sep 2018 05:12:24 PDT (-0700), andrea.parri@xxxxxxxxxxxxxxxxxxxx wrote:
The barriers are unused; remove their definition.

Signed-off-by: Andrea Parri <andrea.parri@xxxxxxxxxxxxxxxxxxxx>
Cc: Palmer Dabbelt <palmer@xxxxxxxxxx>
Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
Cc: <linux-riscv@xxxxxxxxxxxxxxxxxxx>
---
arch/riscv/include/asm/bitops.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h
index f30daf26f08f4..01db98dfd0435 100644
--- a/arch/riscv/include/asm/bitops.h
+++ b/arch/riscv/include/asm/bitops.h
@@ -23,11 +23,6 @@
#include <asm/barrier.h>
#include <asm/bitsperlong.h>

-#ifndef smp_mb__before_clear_bit
-#define smp_mb__before_clear_bit() smp_mb()
-#define smp_mb__after_clear_bit() smp_mb()
-#endif /* smp_mb__before_clear_bit */
-
#include <asm-generic/bitops/__ffs.h>
#include <asm-generic/bitops/ffz.h>
#include <asm-generic/bitops/fls.h>

Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxx>

Do you want me to take this via the RISC-V tree? I only ended up with patch 1/2 in my inbox, and I probably shouldn't take both.

Thanks!