Re: [PATCH v2 17/20] vmw_balloon: compaction support

[Greg Kroah-Hartman]

On Thu, Sep 20, 2018 at 10:30:23AM -0700, Nadav Amit wrote:
> --- a/include/uapi/linux/magic.h
> +++ b/include/uapi/linux/magic.h
> @@ -89,5 +89,6 @@
>  #define UDF_SUPER_MAGIC		0x15013346
>  #define BALLOON_KVM_MAGIC	0x13661366
>  #define ZSMALLOC_MAGIC		0x58295829
> +#define BALLOON_VMW_MAGIC	0xba11007

Any specific reason why you didn't put the leading 0 on your magic
number to make everything align properly?

And there is no need to put this in magic.h, nothing outside of your
code sees this value.  It is not a user api, so please do not make it
one.

thanks,

greg k-h