Re: [PATCH 21/21] platform: goldfish: pipe: Fix allmodconfig build

From: Greg KH
Date: Tue Sep 25 2018 - 14:28:28 EST


On Fri, Sep 14, 2018 at 10:51:22AM -0700, rkir@xxxxxxxxxx wrote:
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
>
> The changes fixes these errors:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/platform/goldfish/goldfish_pipe_v1.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/platform/goldfish/goldfish_pipe_v2.o
> see include/linux/module.h for more information
> ERROR: "goldfish_pipe_device_v2_init" [drivers/platform/goldfish/goldfish_pipe.ko] undefined!
> ERROR: "goldfish_pipe_device_v1_init" [drivers/platform/goldfish/goldfish_pipe.ko] undefined!
> scripts/Makefile.modpost:92: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
> Makefile:1206: recipe for target 'modules' failed
> make: *** [modules] Error 2
>
> Signed-off-by: Roman Kiryanov <rkir@xxxxxxxxxx>
> ---
> drivers/platform/goldfish/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

You can not break the build on one patch, and then fix it up on a later
one. Each patch has to be self-contained and able to be built with no
errors or warnings. So please redo this in the proper place where the
error happened.

thanks,

greg k-h