Re: [PATCH v7 3/6] dt-bindings: leds: Add bindings for lm3697 driver

From: Rob Herring
Date: Tue Sep 25 2018 - 15:39:43 EST


On Mon, Sep 24, 2018 at 1:02 PM Pavel Machek <pavel@xxxxxx> wrote:
>
> Hi!
>
> > > Add the device tree bindings for the lm3697
> > > LED driver for backlighting and display.
> > >
> > > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>
> > > .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++
> > > 1 file changed, 86 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
> >
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> We already have binding for lm3697 in
> Documentation/devicetree/bindings/mfd/ti-lmu.txt . Is it good idea to
> have second one?

Of course not. Now that you mention it, I do remember seeing some
discussion on this.

Rob