Re: [PATCH v2] scsi: sd: don't crash the host on invalid commands

From: Martin K. Petersen
Date: Tue Sep 25 2018 - 20:53:12 EST


> When sd_init_command() get's a with a unknown req_op() it crashes the
> system via BUG().
> This makes debugging the actual reason for the broken request
> cmd_flags pretty hard as the system is down before it's able to write
> out debugging data on the serial console or the trace buffer.
> Change the BUG() to a WARN_ON() and return BLKPREP_KILL to fail
> gracefully and return an I/O error to the producer of the request.

Looks like a bunch of my merge mails didn't make it out last week.

For the record, I did merge this into 4.19/scsi-fixes and it has made
its way upstream.

Martin K. Petersen Oracle Linux Engineering