Re: [PATCH 3/5] lib: Add umoddi3 and udivmoddi4 of GCC library routines
From: Zong Li
Date: Tue Sep 25 2018 - 22:40:19 EST
Christoph Hellwig <hch@xxxxxxxxxxxxx> æ 2018å9æ25æ éä äå11:25åéï
>
> On Tue, Sep 25, 2018 at 10:19:55AM +0800, Zong Li wrote:
> > The RV32 need the umoddi3 to do modulo when the operands are long long
> > type, like other libraries implementation such as ucmpdi2, lshrdi3 and
> > so on. I encounter the undefined reference 'umoddi3' when I use the in
> > house dma driver, although it is in house driver, but I think that
> > umoddi3 is a common function for RV32. The udivmoddi4 and umoddi3 are
> > copies from libgcc in gcc. There are other functions use the
> > udivmoddi4 in libgcc, so I separate the umoddi3 and udivmoddi4 for
> > flexible extension in the future.
>
> I don't think libgcc is GPLv2 licensed, is it? Also please retain
> the copyright notices from libgcc.
I will give next version patch. Thanks.