Re: [PATCH 2/2] ARM: mvebu: Enable ARCH_WANT_LIBATA_LEDS in Armada 38x

From: Aditya Prayoga
Date: Wed Sep 26 2018 - 02:06:10 EST

On Thu, Sep 20, 2018 at 2:26 PM Pavel Machek <pavel@xxxxxx> wrote:
> On Wed 2018-09-19 11:45:30, Aditya Prayoga wrote:
> > Enable hidden symbol ARCH_WANT_LIBATA_LEDS so CONFIG_ATA_LEDS can be
> > used in kernel configuration.
> Should that be hidden symbol and should that be architecture specific?

The intention was to minimize the risk of the ledtrig code being
included by accident. The
code itself does not have architecture specific instruction

> For a notebook, I may want scrolllock LED to indicate ATA activity
> (because I'm using USB keyboard and can't see the disk led).
> Hmm. And while at it... it would be nice to have option to watch all
> ATA ports combined, as well.

but there is disk-activity trigger for that purpose.


> Pavel
> --
> (english)
> (cesky, pictures)