Re: [PATCH 0/3] HiBMC driver fixes

[John Garry]

On 26/09/2018 04:00, Xinliang Liu wrote:
> Thanks John, good addressing!
> The root cause as you said, our hibmc previous frame buffer format
> depth setting is wrong which does not pass the new format sanity
> checking drm_mode_legacy_fb_format.
> For this series,  Reviewed-by: Xinliang Liu <z.liuxinliang@xxxxxxxxxxxxx>
> Applied to hisilicon-drm-next.

I can't see this branch in the git associated with this driver from its 
MAINTAINERS entry (git://github.com/xin3liang/linux.git), but please 
ensure these fixes are included in 4.19

Thanks,
John

> Thanks,
> Xinliang
>
> On Sun, 23 Sep 2018 at 20:32, John Garry <john.garry@xxxxxxxxxx> wrote:
> > This patchset fixes a couple of issues in probing the HiBMC driver, as
> > follows:
> > - fix the probe error path to not carry an error code in the pointer
> > - don't use invalid legacy fb bpp/depth combination
> >
> > Another more trivial patch is for using the standard Huawei PCI vendor ID
> > instead of hard-coding it.
> >
> > Tested on Huawei D05 board. I can see tux on BMC VGA console.
> >
> > John Garry (3):
> >   drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer
> >     pointer
> >   drm/hisilicon: hibmc: Don't overwrite fb helper surface depth
> >   drm/hisilicon: hibmc: Use HUAWEI PCI vendor ID macro
> >
> >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   | 2 +-
> >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > --
> > 1.9.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> .