Re: [PATCH 1/5] PM / Domains: Export symbol for genpd_dev_pm_attach_by_name

[Ulf Hansson]

On 26 September 2018 at 14:27, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
> Export the symbol for genpd_dev_pm_attach_by_name() so that drivers
> built as modules can call this function.
>
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> ---
>  drivers/base/power/domain.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 4b5714199490..b2bbe0d848d2 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2397,6 +2397,7 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev, char *name)
>
>         return genpd_dev_pm_attach_by_id(dev, index);
>  }
> +EXPORT_SYMBOL_GPL(genpd_dev_pm_attach_by_name);

Driver's shouldn't be calling this function, but instead use
dev_pm_domain_attach_by_name().

Is there any problem with that?

[...]

Kind regards
Uffe