Re: [PATCH v2] drivers/thermal/tegra: Fix a double free on the device node
From: Thierry Reding
Date: Wed Sep 26 2018 - 11:25:05 EST
On Mon, Aug 27, 2018 at 09:32:18PM +0800, zhong jiang wrote:
> The function 'for_each_child_of_node' iterates over the node list by
> dropping the of_node reference of the previous node.
>
> Calling of_node_put() on the iterator is pointless and leads to an
> inconsistent refcounting in addition to a double free. Remove it.
>
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> ---
> v1->v2: According to Daniel's suggestion. I modify the subject and commit log.
>
> drivers/thermal/tegra/soctherm.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature