Re: [PATCH] RDMA: fix dependencies for rdma_user_mmap_io

From: Jason Gunthorpe
Date: Wed Sep 26 2018 - 15:51:15 EST


On Wed, Sep 26, 2018 at 09:36:52PM +0200, Arnd Bergmann wrote:
> The mlx4 driver produces a link error when it is configured
> as built-in while CONFIG_INFINIBAND_USER_ACCESS is set to =m:
>
> drivers/infiniband/hw/mlx4/main.o: In function `mlx4_ib_mmap':
> main.c:(.text+0x1af4): undefined reference to `rdma_user_mmap_io'
>
> The same function is called from mlx5, which already has a
> dependency to ensure we can call it, and from hns, which
> appears to suffer from the same problem.
>
> This adds the same dependency that mlx5 uses to the other two.
>
> Fixes: 6745d356ab39 ("RDMA/hns: Use rdma_user_mmap_io")
> Fixes: c282da4109e4 ("RDMA/mlx4: Use rdma_user_mmap_io")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/infiniband/hw/hns/Kconfig | 1 +
> drivers/infiniband/hw/mlx4/Kconfig | 1 +
> 2 files changed, 2 insertions(+)

Woops, thanks Arnd, applied to for-next

Jason