Re: [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block
From: Stefan Agner
Date: Wed Sep 26 2018 - 16:12:47 EST
On 20.09.2018 18:39, Sean Paul wrote:
> On Thu, Sep 20, 2018 at 11:59 AM Leonard Crestez
> <leonard.crestez@xxxxxxx> wrote:
>>
>> On Mon, 2018-09-17 at 16:37 -0700, Stefan Agner wrote:
>> > On 17.09.2018 12:16, Sean Paul wrote:
>> > > On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leonard Crestez wrote:
>> > > > Adding lcdif nodes to a power domain currently doesn't work, it results
>> > > > in black/corrupted screens or hangs. While the driver does enable
>> > > > runtime pm it does not deal correctly with the block being unpowered.
>> > > >
>> > > > All patches in this series have review tags from a while ago and I
>> > > > tested them again on top of next-20180913. No changes
>> > > >
>> > > > This series stalled so I reached out to Marek on IRC and he was
>> > > > surprised to be listed as maintainer
>> > >
>> > > Hopefully not too surprised since Marek added themself to MAINTAINERS when
>> > > adding the driver :-)
>> >
>> > There have been some confusion about the DRM development processes
>> > around the mxsfb already in the past.
>> >
>> > > I suppose we should probably move this to drm-misc since it qualifies as a
>> > > "small driver" and needs a home. Looking through git history shows the last
>> > > mxsfb-specific change was back in 02/17. Everything else has been drm-wide
>> > > refactors. Thoughts?
>> > >
>> > > Marek/Leonard: Care to sign up to be listed as a reviewers?
>> >
>> > drm-misc seems to make sense. I volunteer to be listed as reviewer or co-maintainer.
>>
>> This gets +1 from me, you were very helpful during review.
>>
>> Next would be for one of the drm-misc maintainers to post a change for
>> the MAINTAINER file and also merge my series?
>>
>
> I've posted the MAINTAINERS patch here:
> https://lists.freedesktop.org/archives/dri-devel/2018-September/190414.html
>
> Once I get some Acks, we can merge that and one of Stefan or Marek can apply the
> patchset to drm-misc.
Applied, fixed a white space issue in patch 4 and pushed to drm-misc.
Thanks Sean for helping out here!
And thanks Leonard for working on this and push for its inclusion!
--
Stefan
>
> Sean
>
>> --
>> Regards,
>> Leonard