Re: [PATCH v6 2/2] iio: proximity: vl53l0x: add interrupt support

[Rob Herring]

On Sat, Sep 22, 2018 at 04:05:23PM +0100, Jonathan Cameron wrote:
> On Tue, 18 Sep 2018 16:24:22 +0800
> Song Qiang <songqiang1304521@xxxxxxxxx> wrote:
> 
> > The first version of this driver issues a measuring request and polling
> > for a status register in the device for measuring completes.
> > vl53l0x support configuring GPIO1 on it to generate interrupt to
> > indicate that new measurement is ready. This patch adds support for
> > using this mechanisim to reduce cpu cost.
> > 
> > Signed-off-by: Song Qiang <songqiang1304521@xxxxxxxxx>
> Hi Song.
> 
> Looks correct in principal but a few things to tidy up before
> this is ready to apply.
> 
> Also we have an unrelated change in here to check the devices ID.
> That should be in it's own patch.
> 
> Thanks,
> 
> Jonathan
> > ---
> >  .../bindings/iio/proximity/vl53l0x.txt        |  14 +-

This should have been split with the complete binding in one patch 
rather than piecemeal driver feature by feature.

> >  drivers/iio/proximity/vl53l0x-i2c.c           | 135 +++++++++++++++---
> >  2 files changed, 129 insertions(+), 20 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt b/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt
> > index ab9a9539fec4..40290f8dd70f 100644
> > --- a/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt
> > +++ b/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt
> > @@ -4,9 +4,21 @@ Required properties:
> >  	- compatible: must be "st,vl53l0x-i2c"

Is there more than one interface on this device, such as SPI? If not, 
then '-i2c' should be dropped.

> >  	- reg: i2c address where to find the device
> >  
> > +Optional properties:
> > +	- interrupts : Interrupt line receiving GPIO1's measuring complete
> > +	  output, supports IRQ_TYPE_EDGE_FALLING only.
> > +
> > +	Refer to interrupt-controller/interrupts.txt for generic
> > +	interrupt client node bindings.
> > +
> >  Example:
> >  
> >  vl53l0x@29 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&vl53l0x_pins>;
> > +
> Please drop this from the example.  This is board specific rather than
> being generally required.
> 
> >  	compatible = "st,vl53l0x-i2c";
> >  	reg = <0x29>;
> > -};
> > +	interrupt-parent = <&gpio3>;
> > +	interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
> > +}