Re: [PATCH] misc: cxl: Move a deference below a NULL test
From: Andrew Donnellan
Date: Wed Sep 26 2018 - 19:46:29 EST
On 26/9/18 9:41 pm, zhong jiang wrote:
It is safe to move a deference below a NULL test.
Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
Thanks for catching this.
Acked-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>
---
drivers/misc/cxl/guest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index 3bc0c15..559e835 100644
--- a/drivers/misc/cxl/guest.c
+++ b/drivers/misc/cxl/guest.c
@@ -1018,11 +1018,11 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
void cxl_guest_remove_afu(struct cxl_afu *afu)
{
- pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
-
if (!afu)
return;
+ pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
+
/* flush and stop pending job */
afu->guest->handle_err = false;
flush_delayed_work(&afu->guest->work_err);
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx IBM Australia Limited