Re: [PATCH v2] of: __of_update_property_sysfs only call __of_sysfs_remove_bin_file if of_node_is_attached
From: Frank Rowand
Date: Wed Sep 26 2018 - 21:36:09 EST
On 09/26/18 14:05, Rob Herring wrote:
> On Thu, Sep 13, 2018 at 03:21:27PM +0000, Andre Kalb wrote:
>> Hi Rob,
>>
>> I have used an other hardware to check the patch. I hope it doesnât matter. I added few lines at the untitest.c. All existing unittest use an attached sysfs, therefore the bug isn't detectable.
>
> Okay, can you resend both patches in one series rather than pasted in
> here.
>
> Rob
I don't understand the need for the patch to __of_update_property_sysfs()
in the context of the current mainline Linux kernel.
As far as I know, there are no callers of of_update_property() against
a tree that is detached. As such, the patch is adding complexity
without adding any functionality.
-Frank